linux-kernel - Re: [PATCH] mwifiex: clean up some inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <455eae9e8a583d1ea5b8a3c59e134b85538fff39.camel@sipsolutions.net>
Date:   Sat, 11 Nov 2023 01:57:53 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Jeff Johnson <quic_jjohnson@...cinc.com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        briannorris@...omium.org
Cc:     kvalo@...nel.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] mwifiex: clean up some inconsistent indenting

On Fri, 2023-11-10 at 16:38 -0800, Jeff Johnson wrote:
> > drivers/net/wireless/marvell/mwifiex/sta_event.c:789 mwifiex_process_sta_event() warn: inconsistent indenting.
> > 
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>

> >  		if (!adapter->pps_uapsd_mode &&
> >  		    (priv->port_open ||
> > -		     (priv->bss_mode == NL80211_IFTYPE_ADHOC)) &&
> > +		    (priv->bss_mode == NL80211_IFTYPE_ADHOC)) &&
> 
> this change looks incorrect to me
> this condition is *inside* the parenthesis from the beginning of the
> previous line, and hence this should align after that parenthesis, not
> with that parenthesis, which is what the existing code is doing

Hah, you're right, I completely missed that! I guess someone should fix
their tools :)

johannes