linux-kernel - [PATCH] sched/fair: Remove unnecessary 'curr' reset for pick_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2023 23:43:18 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Juri Lelli <juri.lelli@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Chen Yu <yu.c.chen@...el.com>
Subject: [PATCH] sched/fair: Remove unnecessary 'curr' reset for pick_next_entity()

After commit 4c456c9ad334 ("sched/fair: Remove unused 'curr'
argument from pick_next_entity()"), there is no need to
reset 'curr' to NULL because it will not be used by
pick_next_entity().

Signed-off-by: Chen Yu <yu.c.chen@...el.com>
---
 kernel/sched/fair.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2048138ce54b..ddea1be43710 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8198,8 +8198,6 @@ static struct task_struct *pick_task_fair(struct rq *rq)
 		if (curr) {
 			if (curr->on_rq)
 				update_curr(cfs_rq);
-			else
-				curr = NULL;
 
 			if (unlikely(check_cfs_rq_runtime(cfs_rq)))
 				goto again;
@@ -8249,8 +8247,6 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf
 		if (curr) {
 			if (curr->on_rq)
 				update_curr(cfs_rq);
-			else
-				curr = NULL;
 
 			/*
 			 * This call to check_cfs_rq_runtime() will do the
-- 
2.25.1