linux-kernel - RE: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2023 07:07:13 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'David Airlie'" <airlied@...il.com>,
        "'Daniel Vetter'" <daniel@...ll.ch>,
        "'Maarten Lankhorst'" <maarten.lankhorst@...ux.intel.com>,
        "'Maxime Ripard'" <mripard@...nel.org>,
        "'Thomas Zimmermann'" <tzimmermann@...e.de>,
        "'Rob Herring'" <robh+dt@...nel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@...aro.org>,
        "'Conor Dooley'" <conor+dt@...nel.org>,
        "'Andi Shyti'" <andi.shyti@...nel.org>,
        "'Jonathan Cameron'" <jic23@...nel.org>,
        "'Lars-Peter Clausen'" <lars@...afoo.de>,
        "'Lee Jones'" <lee@...nel.org>,
        "'Ulf Hansson'" <ulf.hansson@...aro.org>,
        "'Tomasz Figa'" <tomasz.figa@...il.com>,
        "'Sylwester Nawrocki'" <s.nawrocki@...sung.com>,
        "'Linus Walleij'" <linus.walleij@...aro.org>,
        "'Thierry Reding'" <thierry.reding@...il.com>,
        'Uwe Kleine-König' 
        <u.kleine-koenig@...gutronix.de>,
        "'Alessandro Zummo'" <a.zummo@...ertech.it>,
        "'Alexandre Belloni'" <alexandre.belloni@...tlin.com>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
        "'Jiri Slaby'" <jirislaby@...nel.org>,
        "'Liam Girdwood'" <lgirdwood@...il.com>,
        "'Mark Brown'" <broonie@...nel.org>,
        "'Jaehoon Chung'" <jh80.chung@...sung.com>,
        "'Sam Protsenko'" <semen.protsenko@...aro.org>,
        <dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        <linux-iio@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
        <linux-rtc@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <linux-sound@...r.kernel.org>
Subject: RE: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific
 compatibles for existing SoC



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only.  This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
> 
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

> ---
> 
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
>  .../mfd/samsung,exynos5433-lpass.yaml         |  2 +-
>  .../bindings/sound/samsung-i2s.yaml           | 19 ++++++++++++-------
>  2 files changed, 13 insertions(+), 8 deletions(-)
(...)