linux-kernel - Re: [PATCH] mpale_tree: remove redundant check on mas_wr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231112153719.63ooidpcb4kgmtco@revolver>
Date:   Sun, 12 Nov 2023 10:37:19 -0500
From:   "Liam R. Howlett" <Liam.Howlett@...cle.com>
To:     Levi Yun <ppbuk5246@...il.com>
Cc:     maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Peng Zhang <zhangpeng.00@...edance.com>
Subject: Re: [PATCH] mpale_tree: remove redundant check on mas_wr_append.

* Levi Yun <ppbuk5246@...il.com> [231111 05:55]:
> Checking data appending on node is done by
>     mas->offsest == end
> which is identical with:
>     mas->offset == wr_mas->node_end
> 
> Remove redundant check and there shouldn't be functional change.

This was already sent out by Peng.

See http://lists.infradead.org/pipermail/maple-tree/2023-November/003051.html

Thanks,
Liam

> 
> Signed-off-by: Levi Yun <ppbuk5246@...il.com>
> ---
>  lib/maple_tree.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index bb24d84a4922..d16b8e211174 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4141,9 +4141,6 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas,
>  	if (mt_in_rcu(mas->tree))
>  		return false;
>  
> -	if (mas->offset != wr_mas->node_end)
> -		return false;
> -
>  	end = wr_mas->node_end;
>  	if (mas->offset != end)
>  		return false;
> -- 
> 2.41.0
>