linux-kernel - Re: [v6.6][PATCH] eventfs: Check for NULL ef in eventfs_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231112123938.58bb5c74@rorschach.local.home>
Date:   Sun, 12 Nov 2023 12:39:38 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Milian Wolff <milian.wolff@...b.com>, akaher@...are.com,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [v6.6][PATCH] eventfs: Check for NULL ef in eventfs_set_attr()

On Sun, 12 Nov 2023 12:18:17 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: "Steven Rostedt (Google)" <rostedt@...dmis.org>
> 
> The top level events directory dentry does not have a d_fsdata set to a
> eventfs_file pointer. This dentry is still passed to eventfs_set_attr().
> It can not assume that the d_fsdata is set. Check for that.
> 
> Link: https://lore.kernel.org/all/20231112104158.6638-1-milian.wolff@kdab.com/
> 
> Fixes: 9aaee3eebc91 ("eventfs: Save ownership and mode")
> Reported-by: Milian Wolff <milian.wolff@...b.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

I guess I should have included the "Cc: stable" tag. This is a bit
different patch since it's not going to land in upstream, as the bug
doesn't exist there.

I can resend if needed.

-- Steve