[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d34527f0-f708-8ec0-33ea-6fd9d4260a6b@huawei.com>
Date: Mon, 13 Nov 2023 13:56:45 +0800
From: Jason Yan <yanaijie@...wei.com>
To: Su Hui <suhui@...china.com>, <jinpu.wang@...ud.ionos.com>,
<jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
<nathan@...nel.org>, <ndesaulniers@...gle.com>, <trix@...hat.com>
CC: <damien.lemoal@...nsource.wdc.com>, <johannes.thumshirn@....com>,
<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<llvm@...ts.linux.dev>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] scsi: pm8001: return error code if no attached dev
Hi, Su
On 2023/11/13 13:01, Su Hui wrote:
> Clang static analyzer complains that value stored to 'res' is never read.
> Return the error code when sas_find_attached_phy_id() failed.
>
> Fixes: ec64858657a8 ("scsi: pm8001: Use sas_find_attached_phy_id() instead of open coding it")
This 'Fixes' tag is not right. This commit is only a refactor and did
not change the original logic here.
Thanks,
Jason
> Signed-off-by: Su Hui <suhui@...china.com>
> ---
> drivers/scsi/pm8001/pm8001_sas.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index a5a31dfa4512..a1f58bfff5c0 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -662,6 +662,8 @@ static int pm8001_dev_found_notify(struct domain_device *dev)
> SAS_ADDR(dev->sas_addr),
> SAS_ADDR(parent_dev->sas_addr));
> res = phy_id;
> + pm8001_free_dev(pm8001_device);
> + goto found_out;
> } else {
> pm8001_device->attached_phy = phy_id;
> }
>
Powered by blists - more mailing lists