linux-kernel - Re: [PATCH v2] i2c: ocores: Move system PM hooks to the NOIRQ phase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0kuf5xm.fsf@48ers.dk>
Date:   Mon, 13 Nov 2023 08:50:13 +0100
From:   Peter Korsgaard <peter@...sgaard.com>
To:     Samuel Holland <samuel.holland@...ive.com>
Cc:     Andrew Lunn <andrew@...n.ch>, Andi Shyti <andi.shyti@...nel.org>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: ocores: Move system PM hooks to the NOIRQ phase

>>>>> "Samuel" == Samuel Holland <samuel.holland@...ive.com> writes:

 > When an I2C device contains a wake IRQ subordinate to a regmap-irq chip,
 > the regmap-irq code must be able to perform I2C transactions during
 > suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must
 > be suspended/resumed during the NOIRQ phase.

 > Signed-off-by: Samuel Holland <samuel.holland@...ive.com>

Acked-by: Peter Korsgaard <peter@...sgaard.com>

> ---

 > Changes in v2:
 >  - Rebase on v6.7-rc1

 >  drivers/i2c/busses/i2c-ocores.c | 4 ++--
 >  1 file changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
 > index 041a76f71a49..e106af83cef4 100644
 > --- a/drivers/i2c/busses/i2c-ocores.c
 > +++ b/drivers/i2c/busses/i2c-ocores.c
 > @@ -771,8 +771,8 @@ static int ocores_i2c_resume(struct device *dev)
 >  	return ocores_init(dev, i2c);
 >  }
 
 > -static DEFINE_SIMPLE_DEV_PM_OPS(ocores_i2c_pm,
 > -				ocores_i2c_suspend, ocores_i2c_resume);
 > +static DEFINE_NOIRQ_DEV_PM_OPS(ocores_i2c_pm,
 > +			       ocores_i2c_suspend, ocores_i2c_resume);
 
 >  static struct platform_driver ocores_i2c_driver = {
 >  	.probe   = ocores_i2c_probe,
 > -- 

 > 2.42.0


-- 
Bye, Peter Korsgaard