linux-kernel - Re: [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpoK1N1LBY5ZjL7hb0Sqge7iF4X=rm1n9VZPx-0nOm3bkw@mail.gmail.com>
Date:   Mon, 13 Nov 2023 12:09:08 +0200
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5:
 enable DP altmode"

On Sat, 11 Nov 2023 at 11:46, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> This reverts commit b3dea914127e9065df003002ed13a2ef40d19877.
>
> The commit introduced unsupported and undocumented properties:
>
>   qrb5165-rb5.dtb: pmic@2: typec@...0:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+'

We need this property to enable DP altmode on RB5. It has been parsed
by the typec subsystem since the commit 7b458a4c5d73 ("usb: typec: Add
typec_port_register_altmodes()"), merged in April 2021.

Rather than landing this commit, let me propose to send the proper
binding instead. If we can not agree on a compatible bindings document
within the sensible timeframe (e.g. 1 month), I'm fine with dropping
of the altmodes from qrb5156-rb5.

>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index c8cd40a462a3..3bd0c06e7315 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -1423,13 +1423,6 @@ PDO_FIXED_DUAL_ROLE |
>                                          PDO_FIXED_USB_COMM |
>                                          PDO_FIXED_DATA_SWAP)>;
>
> -               altmodes {
> -                       displayport {
> -                               svid = <0xff01>;
> -                               vdo = <0x00001c46>;
> -                       };
> -               };
> -
>                 ports {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
> --
> 2.34.1
>
>


-- 
With best wishes
Dmitry