[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231113123049.4117280-1-fshao@chromium.org>
Date: Mon, 13 Nov 2023 20:26:48 +0800
From: Fei Shao <fshao@...omium.org>
To: Hans Verkuil <hverkuil-cisco@...all.nl>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: Fei Shao <fshao@...omium.org>,
Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
Dan Carpenter <dan.carpenter@...aro.org>,
Irui Wang <irui.wang@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Nicolas Dufresne <nicolas.dufresne@...labora.com>,
NĂcolas F. R. A. Prado
<nfraprado@...labora.com>, Tiffany Lin <tiffany.lin@...iatek.com>,
Xiaoyong Lu <xiaoyong.lu@...iatek.com>,
Yunfei Dong <yunfei.dong@...iatek.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: [PATCH 0/4] Improvement around mtk_vcodec_mem_free() logging and usage
This series includes some improvements around mtk_vcodec_mem_free() in
mtk_vcodec_util.c.
I noticed that mtk_vcodec_mem_free() generates a spurious error if the
target DMA buffer has been freed previously:
mtk_vcodec_mem_free(),69: [MTK_V4L2][ERROR] 18000000.video-codec
dma_free size=0 failed!
It's actually harmless, but it brings some confusion to our developers
and testing infra so I'd like to fix it. Then I found some checks around
mtk_vcodec_mem_free() usages in the driver that can optimized together,
so I wrapped both into this series.
The first two patches are for aesthetic and style improvements, the
third suppresses the error mentioned above, and the last removes the
redundant code for optimization.
Regards,
Fei
Fei Shao (4):
media: mediatek: vcodec: Replace dev_name in error string
media: mediatek: vcodec: Drop unnecessary variable
media: mediatek: vcodec: Fix mtk_vcodec_mem_free() error log criteria
media: mediatek: vcodec: Drop VA check against mtk_vcodec_mem_free()
.../mediatek/vcodec/common/mtk_vcodec_util.c | 23 +++++++--------
.../vcodec/decoder/vdec/vdec_av1_req_lat_if.c | 18 ++++--------
.../vcodec/decoder/vdec/vdec_h264_if.c | 9 ++----
.../vcodec/decoder/vdec/vdec_h264_req_if.c | 9 ++----
.../decoder/vdec/vdec_h264_req_multi_if.c | 6 ++--
.../decoder/vdec/vdec_hevc_req_multi_if.c | 9 ++----
.../vcodec/decoder/vdec/vdec_vp8_if.c | 4 +--
.../vcodec/decoder/vdec/vdec_vp8_req_if.c | 12 +++-----
.../vcodec/decoder/vdec/vdec_vp9_if.c | 15 ++++------
.../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 29 +++++++------------
.../mediatek/vcodec/decoder/vdec_msg_queue.c | 15 ++++------
11 files changed, 54 insertions(+), 95 deletions(-)
--
2.42.0.869.gea05f2083d-goog
Powered by blists - more mailing lists