linux-kernel - Re: [PATCH v10 2/3] media: rockchip: Add a driver for Rockchip's camera interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVJAogJsTidx+Cg1@pc-70.home>
Date:   Mon, 13 Nov 2023 16:28:34 +0100
From:   Mehdi Djait <mehdi.djait@...tlin.com>
To:     Michael Riesch <michael.riesch@...fvision.net>
Cc:     mchehab@...nel.org, heiko@...ech.de, hverkuil-cisco@...all.nl,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        conor+dt@...nel.org, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com,
        maxime.chevallier@...tlin.com, paul.kocialkowski@...tlin.com
Subject: Re: [PATCH v10 2/3] media: rockchip: Add a driver for Rockchip's
 camera interface

Hi Michael,

On Fri, Nov 10, 2023 at 03:33:34PM +0100, Michael Riesch wrote:
> Hi Mehdi,
> 
> Sorry, forgot one thing:
> 
> On 11/8/23 17:38, Mehdi Djait wrote:
> > +static int cif_subdev_notifier(struct cif_device *cif_dev)
> > +{
> > +	struct v4l2_async_notifier *ntf = &cif_dev->notifier;
> > +	struct device *dev = cif_dev->dev;
> > +	struct v4l2_async_connection *asd;
> > +	struct v4l2_fwnode_endpoint vep = {
> > +		.bus_type = V4L2_MBUS_PARALLEL,
> 
> This is surprising. I had to set this to V4L2_MBUS_UNKNOWN, otherwise
> v4l2_fwnode_endpoint_parse would yield -ENXIO, which indicates a bus
> type mismatch. Does this really work for your (BT.656, right?) setup?
> 

Yes it works.

> I think we should get the bus type from the device tree, right?
> 

I am looking into this.

> Thanks and best regards,
> Michael
> 

I assume you have a "bus-type = <MEDIA_BUS_TYPE_BT656>;" in the device
tree definition of your endpoint ? This caused the mismatch as the
v4l2_fwnode_endpoint is set to PARALLEL

--
Kind Regards
Mehdi Djait