[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1569460d-30bc-47f5-a224-b14618e4eaf2@linux.intel.com>
Date: Mon, 13 Nov 2023 08:45:03 -0600
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Syed Saba Kareem <Syed.SabaKareem@....com>, broonie@...nel.org,
alsa-devel@...a-project.org
Cc: Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
Sunil-kumar.Dommati@....com, mario.limonciello@....com,
richgong@....com, posteuca@...ex.one,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 2/2] ASoC: amd: acp: add pm ops support for renoir
platform
> @@ -195,7 +196,11 @@ static int renoir_audio_probe(struct platform_device *pdev)
> dev_set_drvdata(dev, adata);
> acp_enable_interrupts(adata);
> acp_platform_register(dev);
> -
> + pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
> + pm_runtime_use_autosuspend(&pdev->dev);
> + pm_runtime_mark_last_busy(&pdev->dev);
> + pm_runtime_set_active(&pdev->dev);
> + pm_runtime_enable(&pdev->dev);
> return 0;
> }
>
> @@ -208,11 +213,42 @@ static void renoir_audio_remove(struct platform_device *pdev)
> acp_platform_unregister(dev);
> }
>
> +static int __maybe_unused rn_pcm_resume(struct device *dev)
> +{
> + struct acp_dev_data *adata = dev_get_drvdata(dev);
> + struct acp_stream *stream;
> + struct snd_pcm_substream *substream;
> + snd_pcm_uframes_t buf_in_frames;
> + u64 buf_size;
> +
> + spin_lock(&adata->acp_lock);
> + list_for_each_entry(stream, &adata->stream_list, list) {
> + substream = stream->substream;
> + if (substream && substream->runtime) {
> + buf_in_frames = (substream->runtime->buffer_size);
> + buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
> + config_pte_for_stream(adata, stream);
> + config_acp_dma(adata, stream, buf_size);
> + if (stream->dai_id)
> + restore_acp_i2s_params(substream, adata, stream);
> + else
> + restore_acp_pdm_params(substream, adata);
when are those parameters saved...
> + }
> + }
> + spin_unlock(&adata->acp_lock);
> + return 0;
> +}
> +
> +static const struct dev_pm_ops rn_dma_pm_ops = {> + SET_SYSTEM_SLEEP_PM_OPS(NULL, rn_pcm_resume)
... since there's nothing done on suspend?
Also there's something weird here since the patch enables pm_runtime but
there's nothing related to pm_runtime here, i.e. SET_RUNTIME_PM_OPS()
is missing.
> +};
> +
> static struct platform_driver renoir_driver = {
> .probe = renoir_audio_probe,
> .remove_new = renoir_audio_remove,
> .driver = {
> .name = "acp_asoc_renoir",
> + .pm = &rn_dma_pm_ops,
> },
> };
>
Powered by blists - more mailing lists