linux-kernel - Re: [PATCH] cifs: spnego: add ';' in HOST_KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05bfafca49fbed96ea500c25a0606205.pc@manguebit.com>
Date:   Mon, 13 Nov 2023 15:11:37 -0300
From:   Paulo Alcantara <pc@...guebit.com>
To:     Anastasia Belova <abelova@...ralinux.ru>,
        Steve French <sfrench@...ba.org>
Cc:     Anastasia Belova <abelova@...ralinux.ru>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Tom Talpey <tom@...pey.com>, Jeff Layton <jlayton@...nel.org>,
        linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org,
        Ekaterina Esina <eesina@...ralinux.ru>
Subject: Re: [PATCH] cifs: spnego: add ';' in HOST_KEY_LEN

Anastasia Belova <abelova@...ralinux.ru> writes:

> "host=" should start with ';' (as in cifs_get_spnego_key)
> So its length should be 6.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 7c9c3760b3a5 ("[CIFS] add constants for string lengths of keynames in SPNEGO upcall string")
> Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
> Co-developed-by: Ekaterina Esina <eesina@...ralinux.ru>
> Signed-off-by: Ekaterina Esina <eesina@...ralinux.ru>
> ---
>  fs/smb/client/cifs_spnego.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@...guebit.com>