linux-kernel - Re: [PATCH] cifs: fix check of rc in function generate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bcf9eb2d4ca5faa17e8e0842c4d69fd.pc@manguebit.com>
Date:   Mon, 13 Nov 2023 15:49:41 -0300
From:   Paulo Alcantara <pc@...guebit.com>
To:     Ekaterina Esina <eesina@...ralinux.ru>,
        Steve French <sfrench@...ba.org>
Cc:     Ekaterina Esina <eesina@...ralinux.ru>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Tom Talpey <tom@...pey.com>, Aurelien Aptel <aaptel@...e.com>,
        linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org,
        Anastasia Belova <abelova@...ralinux.ru>
Subject: Re: [PATCH] cifs: fix check of rc in function generate_smb3signingkey

Ekaterina Esina <eesina@...ralinux.ru> writes:

> Remove extra check after condition, add check after generating key
> for encryption. The check is needed to return non zero rc before
> rewriting it with generating key for decryption.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: d70e9fa55884 ("cifs: try opening channels after mounting")
> Signed-off-by: Ekaterina Esina <eesina@...ralinux.ru>
> Co-developed-by: Anastasia Belova <abelova@...ralinux.ru>
> Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
> ---
>  fs/smb/client/smb2transport.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@...guebit.com>