linux-kernel - Re: [PATCH v3 2/4] platform/x86: hp-bioscfg: move mutex_lock() down in hp_add_other

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <682889a3-2f6e-5141-1f5d-1150119ad1fb@linux.intel.com>
Date:   Mon, 13 Nov 2023 21:11:03 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
cc:     Jorge Lopez <jorge.lopez2@...com>,
        Hans de Goede <hdegoede@...hat.com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Mark Gross <markgross@...nel.org>,
        Thomas Weißschuh <linux@...ssschuh.net>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
        error27@...il.com, vegard.nossum@...cle.com,
        darren.kenny@...cle.com
Subject: Re: [PATCH v3 2/4] platform/x86: hp-bioscfg: move mutex_lock() down
 in hp_add_other_attributes()

On Mon, 13 Nov 2023, Harshit Mogalapalli wrote:

> attr_name_kobj's memory allocation is done with mutex_lock() held, this
> is not needed.
> 
> Move allocation outside of mutex_lock() so unlock is not needed when
> allocation fails.
> 
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.