linux-kernel - Re: [PATCH] PCI: kirin: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <317750f1-c5df-4c2b-9211-b4199f88d248@wanadoo.fr>
Date:   Mon, 13 Nov 2023 20:13:29 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Krzysztof Wilczyński <kw@...ux.com>
Cc:     Xiaowei Song <songxiaowei@...ilicon.com>,
        Binghui Wang <wangbinghui@...ilicon.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-pci@...r.kernel.org, Serge Semin <fancer.lancer@...il.com>
Subject: Re: [PATCH] PCI: kirin: Use devm_kasprintf()

Le 13/11/2023 à 10:55, Krzysztof Wilczyński a écrit :
> Hello!
> 
> [...]
>> @@ -387,9 +386,8 @@ static int kirin_pcie_get_gpio_enable(struct kirin_pcie *pcie,
>>   		if (pcie->gpio_id_clkreq[i] < 0)
>>   			return pcie->gpio_id_clkreq[i];
>>   
>> -		sprintf(name, "pcie_clkreq_%d", i);
>> -		pcie->clkreq_names[i] = devm_kstrdup_const(dev, name,
>> -							    GFP_KERNEL);
>> +		pcie->clkreq_names[i] = devm_kasprintf(dev, GFP_KERNEL,
>> +						       "pcie_clkreq_%d", i);
> 
> I think, the kirin_pcie_parse_port(), which is just below form this
> function, might benefit from the same type of a nice change.  Thoughts?
> 
> 	Krzysztof
> 

Argh, yes, I've not seen it.

I'll send a v2 with both.
Thx for seeing it.

CJ