linux-kernel - Re: [GIT PULL] perf tools changes for v6.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEUSe78g5XUpQ19t4LbeGK4v_PZNTDZ=wjRM325Bm8haiUCoXA@mail.gmail.com>
Date:   Mon, 13 Nov 2023 13:28:18 -0600
From:   Daniel Díaz <daniel.diaz@...aro.org>
To:     Namhyung Kim <namhyung@...nel.org>,
        Yang Jihong <yangjihong1@...wei.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ian Rogers <irogers@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org
Subject: Re: [GIT PULL] perf tools changes for v6.7

Hello!

On Thu, 2 Nov 2023 at 09:06, Namhyung Kim <namhyung@...nel.org> wrote:
> Hi Linus,
>
> Please consider pulling the latest perf tools changes.
>
> Thanks,
> Namhyung
[...]
> Yang Jihong (29):
>       perf evlist: Add perf_evlist__go_system_wide() helper
>       perf evlist: Add evlist__findnew_tracking_event() helper
>       perf record: Move setting tracking events before record__init_thread_masks()
>       perf record: Track sideband events for all CPUs when tracing selected CPUs
>       perf test: Add test case for record sideband events
>       perf test: Add perf_event_attr test for record dummy event
>       perf kwork: Fix incorrect and missing free atom in work_push_atom()
>       perf kwork: Add the supported subcommands to the document
>       perf kwork: Set ordered_events to true in 'struct perf_tool'
>       perf kwork: Add `kwork` and `src_type` to work_init() for 'struct kwork_class'
>       perf kwork: Overwrite original atom in the list when a new atom is pushed.
>       perf kwork: Set default events list if not specified in setup_event_list()
>       perf kwork: Add sched record support
>       perf kwork: Add `root` parameter to work_sort()
>       perf kwork top: Introduce new top utility
[...]

We have found some build regressions on yesterday's 6.7-rc1:
-----8<-----
  builtin-kwork.c: In function 'top_print_work':
  builtin-kwork.c:1646:28: error: format '%ld' expects argument of
type 'long int', but argument 3 has type 'u64' {aka 'long long
unsigned int'} [-Werror=format=]
   1646 |         ret += printf(" %*ld ", PRINT_PID_WIDTH, work->id);
        |                         ~~~^                     ~~~~~~~~
        |                            |                         |
        |                            long int                  u64
{aka long long unsigned int}
        |                         %*lld
  cc1: all warnings being treated as errors
  make[3]: *** [/builds/linux/tools/build/Makefile.build:106:
/home/tuxbuild/.cache/tuxmake/builds/1/build/builtin-kwork.o] Error 1
----->8-----

This is when building for Arm (32-bits) and i386. Bisection points to
commit 55c40e505234 ("perf kwork top: Introduce new top utility").

Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>

To reproduce locally,
  tuxmake \
    --runtime podman \
    --target-arch arm \
    --toolchain gcc-13 \
    --kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/2Y6I5Blgre1fELnAgUTZxqjByvv/config
\
    debugkernel dtbs dtbs-legacy headers kernel modules perf

Greetings!

Daniel Díaz
daniel.diaz@...aro.org