linux-kernel - Re: [PATCH] rtc: cmos: Use ACPI alarm for non-Intel x86 systems too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d55a80f7-ca4d-406f-b2c8-b2bba45e3104@amd.com>
Date:   Mon, 13 Nov 2023 15:36:28 -0600
From:   Mario Limonciello <mario.limonciello@....com>
To:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        alvin.zhuge@...il.com, renzhamin@...il.com, kelvie@...vie.ca,
        Raul Rangel <rrangel@...gle.com>
Subject: Re: [PATCH] rtc: cmos: Use ACPI alarm for non-Intel x86 systems too

On 11/6/2023 10:17, Raul Rangel wrote:
> On Mon, Nov 6, 2023 at 9:14 AM Mario Limonciello
> <mario.limonciello@....com> wrote:
>>
>> Intel systems > 2015 have been configured to use ACPI alarm instead
>> of HPET to avoid s2idle issues.
>>
>> Having HPET programmed for wakeup causes problems on AMD systems with
>> s2idle as well.
>>
>> One particular case is that the systemd "SuspendThenHibernate" feature
>> doesn't work properly on the Framework 13" AMD model. Switching to
>> using ACPI alarm fixes the issue.
>>
>> Adjust the quirk to apply to AMD/Hygon systems from 2021 onwards.
>> This matches what has been tested and is specifically to avoid potential
>> risk to older systems.
>>
>> Cc: stable@...r.kernel.org # 6.1+
>> Reported-by: alvin.zhuge@...il.com
>> Reported-by: renzhamin@...il.com
>> Closes: https://github.com/systemd/systemd/issues/24279
>> Reported-by: Kelvie Wong <kelvie@...vie.ca>
>> Closes: https://community.frame.work/t/systemd-suspend-then-hibernate-wakes-up-after-5-minutes/39392
>> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
>> ---
>>   drivers/rtc/rtc-cmos.c | 18 ++++++++++++------
>>   1 file changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
>> index 228fb2d11c70..696cfa7025de 100644
>> --- a/drivers/rtc/rtc-cmos.c
>> +++ b/drivers/rtc/rtc-cmos.c
>> @@ -818,18 +818,24 @@ static void rtc_wake_off(struct device *dev)
>>   }
>>
>>   #ifdef CONFIG_X86
>> -/* Enable use_acpi_alarm mode for Intel platforms no earlier than 2015 */
>>   static void use_acpi_alarm_quirks(void)
>>   {
>> -       if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
>> +       switch (boot_cpu_data.x86_vendor) {
>> +       case X86_VENDOR_INTEL:
>> +               if (dmi_get_bios_year() < 2015)
>> +                       return;
>> +               break;
>> +       case X86_VENDOR_AMD:
>> +       case X86_VENDOR_HYGON:
>> +               if (dmi_get_bios_year() < 2021)
>> +                       return;
>> +               break;
>> +       default:
>>                  return;
>> -
>> +       }
>>          if (!is_hpet_enabled())
>>                  return;
>>
>> -       if (dmi_get_bios_year() < 2015)
>> -               return;
>> -
>>          use_acpi_alarm = true;
>>   }
>>   #else
>> --
>> 2.34.1
>>
> Acked-by: Raul E Rangel <rrangel@...omium.org>

Now that the merge window is over, can this be picked up?

All of those people who reported it have also reported on the matching 
trackers that it helped their issue.

Thanks!