linux-kernel - Re: [PATCH v4 1/2] tg3: Move the [rt]x_dropped counters to tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231113173830.4c01d551@kernel.org>
Date:   Mon, 13 Nov 2023 17:38:30 -0500
From:   Jakub Kicinski <kuba@...nel.org>
To:     <mchan@...adcom.com>
Cc:     <alexey.pakhunov@...cex.com>, <vincent.wong2@...cex.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <siva.kallam@...adcom.com>, <prashant@...adcom.com>
Subject: Re: [PATCH v4 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi

On Mon, 13 Nov 2023 10:23:49 -0800 alexey.pakhunov@...cex.com wrote:
> This change moves [rt]x_dropped counters to tg3_napi so that they can be
> updated by a single writer, race-free.

Michael, do you have a preference on the using u64_stats_inc() ?
Since we're only doing inc here the conversion should be pretty
trivial. The semantics of local64 are a bit murky but looks like
other drivers think that it's okay to use inc without
u64_stats_update_begin() / end().