linux-kernel - Re: [LINUX PATCH v2 2/3] dt-bindings: timer: Add bindings for TTC PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a68ffc93-1ba7-433d-87b5-a6f2bed0173a@linaro.org>
Date:   Tue, 14 Nov 2023 22:08:31 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mubin Sayyed <mubin.sayyed@....com>,
        krzysztof.kozlowski+dt@...aro.org, u.kleine-koenig@...gutronix.de,
        thierry.reding@...il.com, robh+dt@...nel.org, conor+dt@...nel.org,
        tglx@...utronix.de, daniel.lezcano@...aro.org, michal.simek@....com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-pwm@...r.kernel.org, git@....com,
        mubin10@...il.com
Subject: Re: [LINUX PATCH v2 2/3] dt-bindings: timer: Add bindings for TTC PWM

On 14/11/2023 13:47, Mubin Sayyed wrote:
> Cadence TTC can act as PWM device, it is supported through
> separate PWM framework based driver. Decision to configure
> specific TTC device as PWM or clocksource/clockevent would
> be done based on presence of "#pwm-cells" property.

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.

Missed comments: subject. I don't understand why Cadence was dropped,
but "bindings" stayed. Opposite of what I asked.

Rest looks good, so with above fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof