[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231114082035.64aa8d58@bootlin.com>
Date: Tue, 14 Nov 2023 08:20:35 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Saravana Kannan <saravanak@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
linux-kernel@...r.kernel.org,
Allan Nielsen <allan.nielsen@...rochip.com>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
Steen Hegelund <steen.hegelund@...rochip.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
stable@...r.kernel.org
Subject: Re: [PATCH v2 1/1] driver core: Keep the supplier fwnode consistent
with the device
Hi Saravana,
On Mon, 13 Nov 2023 12:09:43 -0800
Saravana Kannan <saravanak@...gle.com> wrote:
> On Mon, Nov 13, 2023 at 5:30 AM Herve Codina <herve.codina@...tlin.com> wrote:
> >
> > The commit 3a2dbc510c43 ("driver core: fw_devlink: Don't purge child
> > fwnode's consumer links") introduces the possibility to use the
> > supplier's parent device instead of the supplier itself.
> > In that case the supplier fwnode used is not updated and is no more
> > consistent with the supplier device used.
>
> Looks like you missed this comment from my previous reply.
>
> Nack. It's easier to debug when you know what supplier you were
> pointing to in DT that triggered the creation of the device link.
>
> It can get confusing real quick otherwise.
Sorry,
In the next iteration, I will keep the original supplier handle for
debug prints.
Regards,
Hervé
Powered by blists - more mailing lists