linux-kernel - Re: [PATCH V6 2/4] dt-bindings: clock: add Amlogic C3 peripherals clock controller bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bea3c7d2-ed0d-470d-bbe6-3dc19b41fd01@amlogic.com>
Date:   Tue, 14 Nov 2023 16:49:27 +0800
From:   Xianwei Zhao <xianwei.zhao@...ogic.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Neil Armstrong <neil.armstrong@...aro.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Chuan Liu <chuan.liu@...ogic.com>
Subject: Re: [PATCH V6 2/4] dt-bindings: clock: add Amlogic C3 peripherals
 clock controller bindings

Hi Krzysztof,
      Thanks for your reply.

On 2023/11/10 21:24, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 06/11/2023 09:55, Xianwei Zhao wrote:
>> @@ -0,0 +1,237 @@
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> 
Will delete redundant "bindings" next version.
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>> +/*
>> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
>> + * Author: Chuan Liu <chuan.liu@...ogic.com>
>> + */
>> +
>> +#ifndef _DT_BINDINGS_CLOCK_AMLOGIC_C3_PERIPHERALS_CLKC_H
>> +#define _DT_BINDINGS_CLOCK_AMLOGIC_C3_PERIPHERALS_CLKC_H
>> +
>> +#define CLKID_PLL_SRC                                0
>> +#define CLKID_MCLK_PLL_SRC                   1
>> +#define CLKID_DDR_PLL_SRC                    2
>> +#define CLKID_DDR_PHY_SRC                       3
> 
> Fix the indentation. In all other patchses as well.
> 
Will do
> Best regards,
> Krzysztof
>