linux-kernel - Re: [PATCH AUTOSEL 6.6 09/11] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZVM+af4bbB/Hx5Pd@duo.ucw.cz>
Date:   Tue, 14 Nov 2023 10:31:21 +0100
From:   Pavel Machek <pavel@....cz>
To:     Sasha Levin <sashal@...nel.org>
Cc:     Alex Deucher <alexdeucher@...il.com>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        Mario Limonciello <mario.limonciello@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH AUTOSEL 6.6 09/11] drm/amd: Fix UBSAN
 array-index-out-of-bounds for Powerplay headers

Hi!

> > > From: Alex Deucher <alexander.deucher@....com>
> > > 
> > > [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ]
> > > 
> > > For pptable structs that use flexible array sizes, use flexible arrays.
> > > 
> > > Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926
> > > Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> > > Acked-by: Christian König <christian.koenig@....com>
> > > Signed-off-by: Alex Deucher <alexander.deucher@....com>
> > > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > 
> > I don't think any of these UBSAN flexible array changes are stable material.
> 
> I'll drop it, but in general we've been taking kasan/ubsan/kcsan/...
> annotation fixes since it enables (easier) testing on the LTS trees, and
> for example finding issues specific to those LTS trees.

I believe they should not be in stable, either.

In any case, Documentation/process/stable-kernel-rules.rst should be
updated, because it contradicts current practice.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)