linux-kernel - Re: [PATCH v12] platform/x86: Add Silicom Platform Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06567379-aec8-4376-b9b1-3f719716b5ca@infradead.org>
Date:   Mon, 13 Nov 2023 16:20:12 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Henry Shi <henryshi2018@...il.com>, hbshi69@...mail.com,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        hdegoede@...hat.com, markgross@...nel.org, jdelvare@...e.com,
        linux@...ck-us.net, linux-kernel@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, linux-hwmon@...r.kernel.org
Cc:     hb_shi2003@...oo.com, henrys@...icom-usa.com, wenw@...icom-usa.com
Subject: Re: [PATCH v12] platform/x86: Add Silicom Platform Driver



On 11/13/23 15:19, Randy Dunlap wrote:
> 
> 
> On 11/13/23 13:02, Henry Shi wrote:
>> platform/x86: Add Silicom Platform Driver
>>
>> Add Silicom platform (silicom-platform) Linux driver for Swisscom
>> Business Box (Swisscom BB) as well as Cordoba family products.
>>
>> This platform driver provides support for various functions via
>> the Linux LED framework, GPIO framework, Hardware Monitoring (HWMON)
>> and device attributes.
>>
>> Signed-off-by: Henry Shi <henryshi2018@...il.com>
>> ---
> 
> Hi,
> 
> An x86_64 defconfig + this driver enabled gives me:
> 
> 
> ld: vmlinux.o: in function `silicom_gpio_get':
> silicom-platform.c:(.text+0xae6639): undefined reference to `gpiochip_get_data'
> ld: vmlinux.o: in function `silicom_gpio_get_direction':
> silicom-platform.c:(.text+0xae66a8): undefined reference to `gpiochip_get_data'
> ld: vmlinux.o: in function `silicom_gpio_direction_input':
> silicom-platform.c:(.text+0xae6888): undefined reference to `gpiochip_get_data'
> ld: vmlinux.o: in function `silicom_gpio_set':
> silicom-platform.c:(.text+0xae68d3): undefined reference to `gpiochip_get_data'
> ld: silicom-platform.c:(.text+0xae68de): undefined reference to `gpiochip_get_data'
> ld: vmlinux.o:silicom-platform.c:(.text+0xae69a1): more undefined references to `gpiochip_get_data' follow
> ld: vmlinux.o: in function `silicom_platform_probe':
> silicom-platform.c:(.init.text+0x656b7): undefined reference to `devm_gpiochip_add_data_with_key'


so add
	depends on GPIOLIB
for this driver.

-- 
~Randy