linux-kernel - RE: [PATCH v2] usb: dwc3: add missing of_node_put and platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Nov 2023 11:12:01 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>
CC:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] usb: dwc3: add missing of_node_put and platform_device_put

Hi Sergey,

> On 11/14/23 1:16 PM, Stanley Chang wrote:
> 
> > of_get_compatible_child performs an of_node_get, so an of_node_get is
> 
>    You mean of_node_put is required?

Right, it is of_node_put.
I'm sorry for the typo.

Thanks,
Stanley

> > required. Add platform_device_put to match with of_find_device_by_node.
> >
> > Fixes: 34c200483569 ("usb: dwc3: add Realtek DHC RTD SoC dwc3 glue layer
> driver")
> > Signed-off-by: Stanley Chang <stanley_chang@...ltek.com>
> > Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
> > ---
> > v1 to v2 change:
> >     1. Modify the commit message.
> >     2. Add of_node_get in the of_property_read_string() error path.
> [...]
> 
> MBR, Sergey