linux-kernel - Re: [PATCH V2 1/2] ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79e8a5b1-c4d7-4489-83fc-b86ba6ac7549@amd.com>
Date:   Tue, 14 Nov 2023 18:15:06 +0530
From:   syed saba kareem <ssabakar@....com>
To:     Mario Limonciello <mario.limonciello@....com>,
        Syed Saba Kareem <Syed.SabaKareem@....com>,
        broonie@...nel.org, alsa-devel@...a-project.org
Cc:     Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, richgong@....com, posteuca@...ex.one,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Arnd Bergmann <arnd@...db.de>,
        Venkata Prasad Potturu <venkataprasad.potturu@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 1/2] ASoC: amd: acp: add Kconfig options for acp7.0
 based platform driver


On 11/13/23 21:49, Mario Limonciello wrote:
> On 11/13/2023 06:33, Syed Saba Kareem wrote:
>> ACP7.0 based platform legacy drivers can be built by selecting
>> necessary kernel config option. This patch enables build support
>> of the same.
>>
>> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@....com>
>> ---
>> changes since v1:
>>       - added missing commit message.
>>
>>   sound/soc/amd/acp/Kconfig  | 12 ++++++++++++
>>   sound/soc/amd/acp/Makefile |  2 ++
>>   2 files changed, 14 insertions(+)
>>
>> diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
>> index 5fb322212938..c8ac0027f741 100644
>> --- a/sound/soc/amd/acp/Kconfig
>> +++ b/sound/soc/amd/acp/Kconfig
>> @@ -73,6 +73,18 @@ config SND_AMD_ASOC_ACP63
>>         Say Y if you want to enable AUDIO on ACP6.3
>>         If unsure select "N".
>>   +config SND_AMD_ASOC_ACP70
>> +    tristate "AMD ACP ASOC Acp7.0 Support"
>> +    depends on X86 && PCI
>> +    depends on ACPI
>> +    select SND_SOC_AMD_ACP_PCM
>> +    select SND_SOC_AMD_ACP_I2S
>> +    select SND_SOC_AMD_ACP_PDM
>
> Do you not need:
>
>     select SND_SOC_AMD_ACP_LEGACY_COMMON
>
> Like how ACP63, Rembrandt, and Renoir all select?
>
Yes, this flag is missing will upstream the fix as an incremental patch.
>> +    help
>> +    This option enables Acp7.0 PDM support on AMD platform.
>> +    Say Y if you want to enable AUDIO on ACP7.0
>> +          If unsure select "N".
>> +
>>   config SND_SOC_AMD_MACH_COMMON
>>       tristate
>>       depends on X86 && PCI && I2C
>> diff --git a/sound/soc/amd/acp/Makefile b/sound/soc/amd/acp/Makefile
>> index dd85700f1c5f..ff5f7893b81e 100644
>> --- a/sound/soc/amd/acp/Makefile
>> +++ b/sound/soc/amd/acp/Makefile
>> @@ -15,6 +15,7 @@ snd-acp-pci-objs     := acp-pci.o
>>   snd-acp-renoir-objs     := acp-renoir.o
>>   snd-acp-rembrandt-objs  := acp-rembrandt.o
>>   snd-acp63-objs := acp63.o
>> +snd-acp70-objs := acp70.o
>>     #machine specific driver
>>   snd-acp-mach-objs     := acp-mach-common.o
>> @@ -30,6 +31,7 @@ obj-$(CONFIG_SND_SOC_AMD_ACP_PCI) += snd-acp-pci.o
>>   obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o
>>   obj-$(CONFIG_SND_AMD_ASOC_REMBRANDT) += snd-acp-rembrandt.o
>>   obj-$(CONFIG_SND_AMD_ASOC_ACP63) += snd-acp63.o
>> +obj-$(CONFIG_SND_AMD_ASOC_ACP70) += snd-acp70.o
>>     obj-$(CONFIG_SND_SOC_AMD_MACH_COMMON) += snd-acp-mach.o
>>   obj-$(CONFIG_SND_SOC_AMD_LEGACY_MACH) += snd-acp-legacy-mach.o
>