linux-kernel - Re: [PATCH 6/7] xen/events: modify internal [un]bind interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Nov 2023 13:45:02 +0000
From:   Oleksandr Tyshchenko <Oleksandr_Tyshchenko@...m.com>
To:     Juergen Gross <jgross@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Stefano Stabellini <sstabellini@...nel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH 6/7] xen/events: modify internal [un]bind interfaces

On 16.10.23 09:28, Juergen Gross wrote:

Hello Juergen

> Modify the internal bind- and unbind-interfaces to take a struct
> irq_info parameter. When allocating a new IRQ pass the pointer from
> the allocating function further up.
> 
> This will reduce the number of info_for_irq() calls and make the code
> more efficient.
> 
> Signed-off-by: Juergen Gross <jgross@...e.com>

I didn't spot obvious issues with current patch, other than just the 
fact that patch needs rebasing (some hunks cannot be applied because of
"e64e7c74b99e xen/events: avoid using info_for_irq() in 
xen_send_IPI_one()" went in).

I was going to ask why "pirq_query_unmask()/pirq_from_irq()" wasn't
converted to take a struct irq_info parameter as well, but looking at 
the rest I noticed this was already done in subsequent commit.

With proper rebasing:
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>

[snip]