linux-kernel - Re: [PATCH v2 1/1] lib/vsprintf: Fix %pfwf when current node refcount == 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231114161341.2651d393@bootlin.com>
Date:   Tue, 14 Nov 2023 16:13:41 +0100
From:   Herve Codina <herve.codina@...tlin.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Saravana Kannan <saravanak@...gle.com>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org,
        Allan Nielsen <allan.nielsen@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Steen Hegelund <steen.hegelund@...rochip.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH v2 1/1] lib/vsprintf: Fix %pfwf when current node
 refcount == 0

Hi Andy,

On Tue, 14 Nov 2023 16:59:35 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

[...]

> 
> One nit-pick below, otherwise
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> ...
> 
> >  	/* Loop starting from the root node to the current node. */
> >  	for (depth = fwnode_count_parents(fwnode); depth >= 0; depth--) {
> > -		struct fwnode_handle *__fwnode =
> > -			fwnode_get_nth_parent(fwnode, depth);
> > +		/*
> > +		 * Only get a reference for other nodes (ie parents node).  
> 
> "parent's node" (doesn't look right)? Or "parent nodes"?
> 

Will be changed to "parent nodes" in the next iteration.

Best regards,
Hervé