linux-kernel - Re: [PATCH v4 0/2] tee: optee: Fixes for supplicant dependent enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHUa44FoiOinGHyB=P4EL+iMNA3KiLBzfCUw=wGpJuFzo_PMOA@mail.gmail.com>
Date:   Tue, 14 Nov 2023 16:42:51 +0100
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Sumit Garg <sumit.garg@...aro.org>
Cc:     op-tee@...ts.trustedfirmware.org, jan.kiszka@...mens.com,
        arnd@...aro.org, ardb@...nel.org, jerome.forissier@...aro.org,
        ilias.apalodimas@...aro.org, masahisa.kojima@...aro.org,
        maxim.uvarov@...aro.org, jarkko.sakkinen@...ux.intel.com,
        linux-kernel@...r.kernel.org, diogo.ivo@...mens.com
Subject: Re: [PATCH v4 0/2] tee: optee: Fixes for supplicant dependent enumeration

On Thu, Nov 2, 2023 at 8:31 AM Sumit Garg <sumit.garg@...aro.org> wrote:
>
> Currently supplicant dependent optee device enumeration only registers
> devices whenever tee-supplicant is invoked for the first time. But it
> forgets to remove devices when tee-supplicant daemon stops running and
> closes its context gracefully. This leads to following error for fTPM
> driver during reboot/shutdown:
>
> [   73.466791] tpm tpm0: ftpm_tee_tpm_op_send: SUBMIT_COMMAND invoke error: 0xffff3024
>
> Fix this by adding an attribute for supplicant dependent devices so that
> the user-space service can detect and detach supplicant devices before
> closing the supplicant:
>
> $ for dev in /sys/bus/tee/devices/*; do if [[ -f "$dev/need_supplicant" && -f "$dev/driver/unbind" ]]; \
>       then echo $(basename "$dev") > $dev/driver/unbind; fi done
>
> While at it use the global system workqueue for OP-TEE bus scanning work
> rather than our own custom one.
>
> Changes in v4:
> - Changing the device name would be an ABI break, rather switch to
>   additional device attribute: "need_supplicant" to distinguish for ABI
>   compatibility.
> - Dropped tested-by for patch #1, I would encourage folks to retest
>   this.
>
> Changes in v3:
>
> - Split patch into 2 separate ones, one for supplicant fix and other for
>   the workqueue.
>
> Changes in v2:
>
> - Use device names to separate out tee-supplicant dependent devices via
>   this patch.
> - Since user-space service is aware about tee-supplicant lifespan, so
>   allow the user-space service to unbind tee-supplicant dependent
>   devices before killing the supplicant. Following command has to be
>   added to the tee-supplicant service file.
>
>   $ for dev in /sys/bus/tee/devices/*; do if [[ "$dev" == *"optee-ta-supp-"* ]]; \
>         then echo $(basename "$dev") > $dev/driver/unbind; fi done
>
> Sumit Garg (2):
>   tee: optee: Fix supplicant based device enumeration
>   tee: optee: Remove redundant custom workqueue
>
>  .../ABI/testing/sysfs-bus-optee-devices         |  9 +++++++++
>  drivers/tee/optee/core.c                        | 13 ++-----------
>  drivers/tee/optee/device.c                      | 17 +++++++++++++++--
>  drivers/tee/optee/optee_private.h               |  2 --
>  4 files changed, 26 insertions(+), 15 deletions(-)
>
> --
> 2.34.1
>

I'm picking up this.

Thanks,
Jens