linux-kernel - Re: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e5ce0994-6698-3ade-4553-76d456fe9110@quicinc.com>
Date:   Tue, 14 Nov 2023 09:03:04 -0700
From:   Jeffrey Hugo <quic_jhugo@...cinc.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>, <daniel@...ll.ch>
CC:     <maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
        <tzimmermann@...e.de>, <airlied@...il.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and
 alloc_ordered_workqueue()

On 1/17/2023 8:24 PM, Jiasheng Jiang wrote:
>> On Tue, Jan 10, 2023 at 11:24:47PM +0800, Jiasheng Jiang wrote:
>>> Add drmm_alloc_workqueue() and drmm_alloc_ordered_workqueue(), the helpers
>>> that provide managed workqueue cleanup. The workqueue will be destroyed
>>> with the final reference of the DRM device.
>>>
>>> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
>>
>> Yeah I think this looks nice.
>>
>> Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
>>
>> I'm assuming driver maintainers will pick this up, if not please holler.
>>
>> Also the threading seems broken, it's not a patch series. The b4 tool or
>> git send-email (of all the patches of the entire series at once, not each
>> individually) should get this right.
>>
>> Unfortunately I did't find the right link in the kernel docs, or at least
>> they're not as detailed as I hoped.
>>
>> Also your previous submission had iirc a bunch more patches, do you plan
>> to include them all in the next patch set?
> 
> I have found that some previous patches have already been applied.
> Need I just convert alloc*workqueue into drmm_alloc*workqueue and remove
> the destroy_workqueue?
> Or need I convert all the alloc*workqueue in the DRM?
> 
> Thanks,
> Jiang

Unless I'm missing something, I don't see that this ever got applied.  I 
have a use for this interface in the qaic driver.

Jiang, are you planning on posting a v2?

-Jeff