linux-kernel - Re: [V14 0/8] arm64/perf: Enable branch stack sampling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af04e269-d43d-0dd6-5434-3cea9c74be01@arm.com>
Date:   Tue, 14 Nov 2023 17:17:28 +0000
From:   James Clark <james.clark@....com>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
        Marc Zyngier <maz@...nel.org>,
        Suzuki Poulose <suzuki.poulose@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-perf-users@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        will@...nel.org, catalin.marinas@....com, mark.rutland@....com
Subject: Re: [V14 0/8] arm64/perf: Enable branch stack sampling



On 14/11/2023 05:13, Anshuman Khandual wrote:
> This series enables perf branch stack sampling support on arm64 platform
> via a new arch feature called Branch Record Buffer Extension (BRBE). All
> the relevant register definitions could be accessed here.
> 
[...]
> 
> --------------------------- Virtualisation support ------------------------
> 
> - Branch stack sampling is not currently supported inside the guest (TODO)
> 
> 	- FEAT_BRBE advertised as absent via clearing ID_AA64DFR0_EL1.BRBE
> 	- Future support in guest requires emulating FEAT_BRBE

If you never add support for the host looking into a guest, and you save
and restore all the BRBINF[n] registers, I think you might be able to
just let the guest do whatever it wants with BRBE and not trap and
emulate it? Maybe there is some edge case why that wouldn't work, but
it's worth thinking about.

For BRBE specifically I don't see much of a use case for hosts looking
into a guest, at least not like with PMU counters.

> 
> - Branch stack sampling the guest is not supported in the host      (TODO)
> 
> 	- Tracing the guest with event->attr.exclude_guest = 0
> 	- There are multiple challenges involved regarding mixing events
> 	  with mismatched branch_sample_type and exclude_guest and passing
> 	  on captured BRBE records to intended events during PMU interrupt
> 
> - Guest access for BRBE registers and instructions has been blocked
> 
> - BRBE state save is not required for VHE host (EL2) guest (EL1) transition
> 
> - BRBE state is saved for NVHE host (EL1) guest (EL1) transition
> 
> -------------------------------- Testing ---------------------------------
> 
> - Cross compiled for both arm64 and arm32 platforms
> - Passes all branch tests with 'perf test branch' on arm64
> 
> -------------------------------- Questions -------------------------------
> 
> - Instead of configuring the BRBE HW with branch_sample_type from the last
>   event to be added on the PMU as proposed, could those be merged together
>   e.g all privilege requests ORed, to form a common BRBE configuration and
>   all events get branch records after a PMU interrupt ?
>