linux-kernel - Re: [PATCH] linux/export: clean up the IA-64 KSYM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231114200508.GA3378955@dev-arch.thelio-3990X>
Date:   Tue, 14 Nov 2023 13:05:08 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Helge Deller <deller@....de>, linux-kbuild@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] linux/export: clean up the IA-64 KSYM_FUNC macro

On Fri, Nov 10, 2023 at 01:07:22PM +0100, Lukas Bulwahn wrote:
> With commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture"),
> there is no need to keep the IA-64 definition of the KSYM_FUNC macro.
> 
> Clean up the IA-64 definition of the KSYM_FUNC macro.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

I see you sent a patch for the other instance of CONFIG_IA64 that I see
in tree still. LGTM.

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  include/linux/export-internal.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/linux/export-internal.h b/include/linux/export-internal.h
> index 45fca09b2319..69501e0ec239 100644
> --- a/include/linux/export-internal.h
> +++ b/include/linux/export-internal.h
> @@ -50,9 +50,7 @@
>  	    "	.previous"						"\n"	\
>  	)
>  
> -#ifdef CONFIG_IA64
> -#define KSYM_FUNC(name)		@fptr(name)
> -#elif defined(CONFIG_PARISC) && defined(CONFIG_64BIT)
> +#if defined(CONFIG_PARISC) && defined(CONFIG_64BIT)
>  #define KSYM_FUNC(name)		P%name
>  #else
>  #define KSYM_FUNC(name)		name
> -- 
> 2.17.1
>