linux-kernel - Re: [RESEND PATCH] pwm: Use device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231115213451.cvrmuzdbtfrpysth@pengutronix.de>
Date:   Wed, 15 Nov 2023 22:34:51 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Rob Herring <robh@...nel.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Heiko Stuebner <heiko@...ech.de>, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [RESEND PATCH] pwm: Use device_get_match_data()

Hello Rob,

this is a resend of v2, I'd say. Would have been helpful to indicate
that in the Subject line.

On Wed, Nov 15, 2023 at 03:01:20PM -0600, Rob Herring wrote:
> Use preferred device_get_match_data() instead of of_match_device() to
> get the driver match data. With this, adjust the includes to explicitly
> include the correct headers.
> 
> As these drivers only do DT based matching, of_match_device() will never
> return NULL if we've gotten to probe(). Therefore, the NULL check and
> error returns can be dropped.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

I send a Reviewed-by tag in reply to (original) v2 that wasn't added
here. As v2 is still "new" in the pwm patchwork, I'll mark this resend
as non-actionable.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)