[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8489c4db-6639-43f5-b6c4-8598652cdce6@suswa.mountain>
Date: Wed, 15 Nov 2023 17:42:17 -0500
From: Dan Carpenter <dan.carpenter@...aro.org>
To: mripard@...nel.org
Cc: Naresh Kamboju <naresh.kamboju@...aro.org>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Kees Cook <keescook@...omium.org>,
Daniel Díaz <daniel.diaz@...aro.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Brendan Higgins <brendan.higgins@...ux.dev>,
David Gow <davidgow@...gle.com>,
Maíra Canal <mcanal@...lia.com>,
Arthur Grillo <arthurgrillo@...eup.net>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
kernel-janitors@...r.kernel.org,
Ville Syrjälä
<ville.syrjala@...ux.intel.com>, kv-team <kv-team@...aro.org>
Subject: Re: [RFC] drm/tests: annotate intentional stack trace in
drm_test_rect_calc_hscale()
On Mon, Nov 06, 2023 at 02:58:12PM +0100, mripard@...nel.org wrote:
> > But a similar thing is happening here where we have so many bogus
> > warnings that we missed a real bug.
>
> IIRC, there was a similar discussion for lockdep issues. IMO, any
> (unintended) warning should trigger a test failure.
>
> I guess that would require adding some intrumentation to __WARN somehow,
> and also allowing tests to check whether a warning had been generated
> during their execution for tests that want to trigger one.
I think this is a good idea. I was looking at how lockdep prints
warnings (see print_circular_bug_header()). It doesn't use WARN() it
prints a bunch of pr_warn() statements and then a stack trace. We would
have to have a increment the counter manually in that situation.
I'm writing a script to parse a dmesg and collect Oopses. So now I know
to look for WARN(), lockdep, and KASAN. What other bugs formats do we
have? Probably someone like the syzbot devs have already has written a
script like this?
regards,
dan carpenter
Powered by blists - more mailing lists