linux-kernel - Re: [PATCH 7/7] xen/events: remove some info_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfcd84b8-4fb2-42fa-9346-fa447992f8cd@suse.com>
Date:   Wed, 15 Nov 2023 08:41:08 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Oleksandr Tyshchenko <Oleksandr_Tyshchenko@...m.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Stefano Stabellini <sstabellini@...nel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH 7/7] xen/events: remove some info_for_irq() calls in pirq
 handling

On 14.11.23 19:16, Oleksandr Tyshchenko wrote:
> 
> 
> On 16.10.23 09:28, Juergen Gross wrote:
> 
> Hello Juergen
> 
> 
>> Instead of the IRQ number user the struct irq_info pointer as parameter
>> in the internal pirq related functions. This allows to drop some calls
>> of info_for_irq().
>>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
> 
> 
> Looks good, so
> 
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
> 
> 
> Just one NIT below ...
> 
> 
> [snip]
> 
>>    
>> -static void pirq_query_unmask(int irq)
>> +static void pirq_query_unmask(struct irq_info *info)
>>    {
>>    	struct physdev_irq_status_query irq_status;
>> -	struct irq_info *info = info_for_irq(irq);
>>    
>>    	BUG_ON(info->type != IRQT_PIRQ);
>>    
>> -	irq_status.irq = pirq_from_irq(irq);
>> +	irq_status.irq = info->u.pirq.pirq;
> 
> 
>    ... what is the reason to open-code pirq_from_irq() here?
> For example, __startup_pirq() continues to use helper in almost the same
> situation ...

Good catch. I'll change that, especially as it allows to remove the BUG_ON()
which is in the helper already.


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)