[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231115095817.GB3818@noisy.programming.kicks-ass.net>
Date: Wed, 15 Nov 2023 10:58:17 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Jiri Olsa <olsajiri@...il.com>, mingo@...nel.org,
linux-kernel@...r.kernel.org, acme@...nel.org,
mark.rutland@....com, alexander.shishkin@...ux.intel.com,
irogers@...gle.com, adrian.hunter@...el.com
Subject: Re: [PATCH 01/13] perf: Simplify perf_event_alloc() error path
On Fri, Nov 03, 2023 at 12:50:19PM -0700, Namhyung Kim wrote:
> > > -err_pmu:
> > > - if (is_cgroup_event(event))
> > > - perf_detach_cgroup(event);
> > > - if (event->destroy)
> > > - event->destroy(event);
> > > - module_put(pmu->module);
>
> I'm afraid of this part. If it failed at perf_init_event(), it might
> call event->destroy() already. I saw you cleared event->pmu
> in the failure path. Maybe we need the same thing for the
> event->destroy.
In that case event->destroy will not yet have been set, no?
And once it is set, we should call it.
Powered by blists - more mailing lists