linux-kernel - Re: [PATCH v2] pinctrl: avoid reload of p state in list iteration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbmw=goFFiSYOC4_ybiHiiBJJqmVv2Gh=v5nuTnQ1Z1Gg@mail.gmail.com>
Date:   Wed, 15 Nov 2023 10:58:58 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Maria Yu <quic_aiquny@...cinc.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...cinc.com, stable@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: avoid reload of p state in list iteration

Hi Maria,

On Wed, Nov 15, 2023 at 2:13 AM Maria Yu <quic_aiquny@...cinc.com> wrote:

> When in the list_for_each_entry iteration, reload of p->state->settings
> with a local setting from old_state will makes the list iteration in a
> infinite loop.
> The typical issue happened, it will frequently have printk message like:
>   "not freeing pin xx (xxx) as part of deactivating group xxx - it is
> already used for some other setting".
> This is a compiler-dependent problem, one instance was got using Clang
> version 10.0 plus arm64 architecture.
>
> Signed-off-by: Maria Yu <quic_aiquny@...cinc.com>
> Cc: stable@...r.kernel.org

Thanks, very much to the point.

Can you please send a v3 and add the info Andy requested too,
and I will apply it!

Yours,
Linus Walleij