linux-kernel - Re: drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting "LOCHNAGAR1_" and "(" does not give a valid preprocessing token

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231115102537.GB32655@ediswmail.ad.cirrus.com>
Date:   Wed, 15 Nov 2023 10:25:37 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     kernel test robot <lkp@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        <oe-kbuild-all@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting
 "LOCHNAGAR1_" and "(" does not give a valid preprocessing token

On Wed, Nov 15, 2023 at 10:57:29AM +0100, Linus Walleij wrote:
> On Wed, Nov 15, 2023 at 10:37 AM Charles Keepax
> <ckeepax@...nsource.cirrus.com> wrote:
> > On Tue, Nov 14, 2023 at 02:40:38PM +0100, Linus Walleij wrote:
> > > On Tue, Nov 7, 2023 at 6:19 AM kernel test robot <lkp@...el.com> wrote:
> > It has somewhat been on my radar to fix at some point, but I have
> > in general been a little unsure how to proceed. RST feels like
> > a mega over generic macro name to be exporting, so in some ways
> > feels like fixing that would be nice. On the other side, renaming
> > the register on the Lochnagar side would be very easy, although it
> > would mean the register naming no longer matches all the hardware
> > documentation which would be kinda lame.
> 
> If MIPS breaks things like this because of weird defines I would say
> it is actually fair to just quirk it in Kconfig with a comment:
> 
>   # MIPS occupy very generic defines
>   depends on !MIPS
> 

Hm... hadn't considered that. The driver is pretty unlikely to be
needed on MIPS anytime soon, so might be a reasonable work around
for now. Would you like me to fire in a patch, or you want to?

Thanks,
Charles