linux-kernel - Re: [PATCH] ceph: quota: Fix invalid pointer access in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875y238drx.fsf@suse.de>
Date:   Wed, 15 Nov 2023 11:19:30 +0000
From:   Luis Henriques <lhenriques@...e.de>
To:     Wenchao Hao <haowenchao2@...wei.com>
Cc:     Xiubo Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
        Jeff Layton <jlayton@...nel.org>, <ceph-devel@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <louhongxiang@...wei.com>
Subject: Re: [PATCH] ceph: quota: Fix invalid pointer access in

Wenchao Hao <haowenchao2@...wei.com> writes:

> This issue is reported by smatch, get_quota_realm() might return
> ERR_PTR, so we should using IS_ERR_OR_NULL here to check the return
> value.
>
> Signed-off-by: Wenchao Hao <haowenchao2@...wei.com>
> ---
>  fs/ceph/quota.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/quota.c b/fs/ceph/quota.c
> index 9d36c3532de1..c4b2929c6a83 100644
> --- a/fs/ceph/quota.c
> +++ b/fs/ceph/quota.c
> @@ -495,7 +495,7 @@ bool ceph_quota_update_statfs(struct ceph_fs_client *fsc, struct kstatfs *buf)
>  	realm = get_quota_realm(mdsc, d_inode(fsc->sb->s_root),
>  				QUOTA_GET_MAX_BYTES, true);
>  	up_read(&mdsc->snap_rwsem);
> -	if (!realm)
> +	if (IS_ERR_OR_NULL(realm))
>  		return false;
>  
>  	spin_lock(&realm->inodes_with_caps_lock);
> -- 
>
> 2.32.0
>

This looks right to me, the issue was introduced by commit 0c44a8e0fc55
("ceph: quota: fix quota subdir mounts").  FWIW:

Reviewed-by: Luis Henriques <lhenriques@...e.de>

Cheers,
-- 
Luís