linux-kernel - Re: [PATCH v1 2/2] usb: misc: onboard-hub: add support for Microchip USB5744

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8e52587-5ad2-46ac-a5a8-71738b9f5ac7@amd.com>
Date:   Wed, 15 Nov 2023 12:20:35 +0100
From:   Michal Simek <michal.simek@....com>
To:     Francesco Dolcini <francesco@...cini.it>,
        Matthias Kaehlcke <mka@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Stefan Eichenberger <stefan.eichenberger@...adex.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Subject: Re: [PATCH v1 2/2] usb: misc: onboard-hub: add support for Microchip
 USB5744



On 11/13/23 15:59, Francesco Dolcini wrote:
> From: Stefan Eichenberger <stefan.eichenberger@...adex.com>
> 
> Add support for the Microchip USB5744 USB3.0 and USB2.0 Hub.
> 
> The Microchip USB5744 supports two power supplies, one for 1V2 and one
> for 3V3. According to the datasheet there is no need for a delay between
> power on and reset, so this value is set to 0.
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@...adex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>

The patch is correct based on functionality you want to add. Would be good to 
also add support for initialization over i2c which will change couple of things.

Thanks,
Michal