[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <863a0fe2-c258-47d9-8563-6f12bb55b4ad@linaro.org>
Date: Wed, 15 Nov 2023 13:13:29 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Zev Weiss <zev@...ilderbeest.net>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...econstruct.com.au>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
openbmc@...ts.ozlabs.org
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: Add ASRock E3C256D4I BMC
On 14/11/2023 23:37, Zev Weiss wrote:
>
>>> + };
>>> +
>>> + memory@...00000 {
>>> + reg = <0x80000000 0x20000000>;
>>> + };
>>> +
>>> + leds {
>>> + compatible = "gpio-leds";
>>> +
>>> + heartbeat {
>>
>> It does not look like you tested the DTS against bindings. Please run
>> `make dtbs_check W=1` (see
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
The node names are clearly wrong and you got output. It's easy to spot
if your patch worked in the first place:
fatal error: dt-bindings/watchdog/aspeed-wdt.h: No such file or directory
Best regards,
Krzysztof
Powered by blists - more mailing lists