[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4f431cc6-4f13-47bb-ba35-44bddf047e02@linaro.org>
Date: Wed, 15 Nov 2023 13:17:34 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>,
Conor Dooley <conor@...nel.org>
Cc: "patrick@...cx.xyz" <patrick@...cx.xyz>,
Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Jonathan Corbet <corbet@....net>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver
bindings
On 15/11/2023 09:38, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
>> -----Original Message-----
>> From: Conor Dooley <conor@...nel.org>
>> Sent: Friday, November 10, 2023 1:10 AM
>> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>
>> Cc: patrick@...cx.xyz; Jean Delvare <jdelvare@...e.com>; Guenter Roeck
>> <linux@...ck-us.net>; Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley <conor+dt@...nel.org>;
>> Jonathan Corbet <corbet@....net>; linux-i2c@...r.kernel.org;
>> linux-hwmon@...r.kernel.org; devicetree@...r.kernel.org;
>> linux-kernel@...r.kernel.org; linux-doc@...r.kernel.org
>> Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver
>> bindings
>>
>> On Thu, Nov 09, 2023 at 09:49:45AM +0800, Delphine CC Chiu wrote:
>>> Add a device tree bindings for ltc4286 device.
>>>
>>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
>>>
>>> Changelog:
>>> v4 - Revise some inappropriate writing in yaml file
>>> v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable
>>> v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6
>>> - Add type for adi,vrange-select-25p6
>>> - Revise rsense-micro-ohms to shunt-resistor-micro-ohms
>>
>> Your changelog should be below the --- line.
>
> We will add --- line on our changelog.
>
>> You also omitted the tag I left on the previous version.
>
> Could you point out the exact places that we omit?
Open the previous email and read it fully. Did you or did you not get a tag?
> Thanks.
>
>> With the changelog fixed:
>> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
Best regards,
Krzysztof
Powered by blists - more mailing lists