linux-kernel - Re: [PATCH v2] gpio: sifive: remove unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mc=nzkTxVyYkg0y8r5cW9MDKD7LZggfmj2jtaq68yamFw@mail.gmail.com>
Date:   Wed, 15 Nov 2023 15:40:02 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Samuel Holland <samuel.holland@...ive.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andy@...nel.org>,
        Andrei Coardos <aboutphysycs@...il.com>,
        Alexandru Ardelean <alex@...uggie.ro>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2] gpio: sifive: remove unneeded call to platform_set_drvdata()

On Mon, Nov 13, 2023 at 3:34 AM Samuel Holland
<samuel.holland@...ive.com> wrote:
>
> From: Andrei Coardos <aboutphysycs@...il.com>
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> Reviewed-by: Andy Shevchenko <andy@...nel.org>
> Signed-off-by: Samuel Holland <samuel.holland@...ive.com>
> ---

Applied, thanks!

Bart