[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <65077e87-25a6-40dd-a81d-8a6987979b28@kylinos.cn>
Date: Wed, 15 Nov 2023 11:10:14 +0800
From: Kunwu Chan <chentao@...inos.cn>
To: Simon Horman <horms@...nel.org>
Cc: jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, jeffrey.t.kirsher@...el.com,
shannon.nelson@....com, kunwu.chan@...mail.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH] i40e: Use correct buffer size
Hi Simon,
Thank you very much for taking the valuable time to point out my
problems and shortcomings in detail.
It's my bad.I misinterpreted 'IFALIASZ' in 'include/uapi/linux/if.h' as
'IFNAMSIZ'. This led me to think that 'IFNAMSIZ' could be up to 256.
Sorry again for the trouble.
Yes, it is good code to dynamically calculate the size of the parts that
make up the 'buffer' and add them up to the size of the whole 'buffer',
I got lazy because I saw that the other parts had a lot of fixed 'buffer
size'. I will immediately modify the patch according to your detailed
suggestions.
From the code analysis, this place should have a 'snprintf truncation'
problem, but the impact may not be very big, I found the potential
problem during the compilation process, after changing the buffer size,
recompilation will not alarm.
I'll follow your detailed suggestions and remove the 'Fixes' tag and add
'iwl-next' to the subject.
Thank you again for your reply and guidance.
在 2023/11/13 17:31, Simon Horman 写道:
> [PATCH iwl-next]
Powered by blists - more mailing lists