linux-kernel - Re: [PATCH] drivers: target: Fixed multiple typos in multiple files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq17cmj10bl.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 15 Nov 2023 11:12:53 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Muhammad Muzammil <m.muzzammilashraf@...il.com>
Cc:     martin.petersen@...cle.com, bostroesser@...il.com,
        michael.christie@...cle.com, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: target: Fixed multiple typos in multiple files


Hi Muhammad,

> -	 * CID we do connection reinstatement.  Currently we dont not
> +	 * CID we do connection reinstatement.  Currently we don't not

"Currently we don't not" does not parse. Fixing misspelled words in
isolation is not necessarily an improvement. The criteria should be
whether the entire sentence or comment becomes easier to read.

> -		 * status, with the sense key set to ILLEGAL REQUEST,and the additonal
> +		 * status, with the sense key set to ILLEGAL REQUEST,and the additional

There's a space missing after "ILLEGAL REQUEST,".

> - * Called thru fc_lport_iterate().
> + * Called through fc_lport_iterate().

"thru" is perfectly valid and the author's choice.

-- 
Martin K. Petersen	Oracle Linux Engineering