linux-kernel - Re: [PATCH v3] perf report: Add s390 raw data interpretation for PAI counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZVUHGRgTBXyUjezY@kernel.org>
Date:   Wed, 15 Nov 2023 12:59:53 -0500
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Thomas Richter <tmricht@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        sumanthk@...ux.ibm.com, svens@...ux.ibm.com, gor@...ux.ibm.com,
        hca@...ux.ibm.com
Subject: Re: [PATCH v3] perf report: Add s390 raw data interpretation for PAI
 counters

Em Sat, Nov 11, 2023 at 09:10:56AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Nov 10, 2023 at 09:10:56AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Nov 10, 2023 at 12:09:08PM +0100, Thomas Richter escreveu:
> > > +/*
> > > + * Check for consistency of PAI_CRYPTO/PAI_NNPA raw data.
> > > + */
> > > +struct pai_data {		/* Event number and value */
> > > +	u16 event_nr;
> > > +	u64 event_val;
> > > +} __packed;
 
> We'll have to disable this warning:
> 
>   19    10.55 debian:experimental-x-mips    : FAIL gcc version 12.3.0 (Debian 12.3.0-6)
>     util/s390-sample-raw.c:222:13: error: packed attribute causes inefficient alignment for 'event_nr' [-Werror=attributes]
>       222 |         u16 event_nr;
>           |             ^~~~~~~~
>     cc1: all warnings being treated as errors
 
> I'll do it while waiting for flights later today.

this got it cured, pushing out.

- Arnaldo

diff --git a/tools/perf/util/s390-sample-raw.c b/tools/perf/util/s390-sample-raw.c
index d4dc84aa889a04cf..29a744eeb71eb2bd 100644
--- a/tools/perf/util/s390-sample-raw.c
+++ b/tools/perf/util/s390-sample-raw.c
@@ -215,6 +215,9 @@ static void s390_cpumcfdg_dump(struct perf_pmu *pmu, struct perf_sample *sample)
 	}
 }
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wpacked"
+#pragma GCC diagnostic ignored "-Wattributes"
 /*
  * Check for consistency of PAI_CRYPTO/PAI_NNPA raw data.
  */
@@ -223,6 +226,8 @@ struct pai_data {		/* Event number and value */
 	u64 event_val;
 } __packed;
 
+#pragma GCC diagnostic pop
+
 /*
  * Test for valid raw data. At least one PAI event should be in the raw
  * data section.