linux-kernel - Re: [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2023 06:56:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tzuyi Chang <tychang@...ltek.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Shevchenko <andy@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        TY Chang <tychang@...ltek.com>
Subject: Re: [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home
 Center) RTD SoCs.

Hi Tzuyi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on brgl/gpio/for-next]
[also build test WARNING on robh/for-next linus/master v6.7-rc1 next-20231116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tzuyi-Chang/dt-bindings-gpio-realtek-Add-realtek-rtd-gpio/20231116-191928
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link:    https://lore.kernel.org/r/20231116111441.2339-3-tychang%40realtek.com
patch subject: [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs.
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20231117/202311170603.TawAUggC-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231117/202311170603.TawAUggC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311170603.TawAUggC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpio/gpio-rtd.c:71: warning: Function parameter or member 'num_dir' not described in 'rtd_gpio_info'
>> drivers/gpio/gpio-rtd.c:71: warning: Function parameter or member 'num_dato' not described in 'rtd_gpio_info'
>> drivers/gpio/gpio-rtd.c:71: warning: Function parameter or member 'num_dati' not described in 'rtd_gpio_info'
>> drivers/gpio/gpio-rtd.c:71: warning: Function parameter or member 'num_ie' not described in 'rtd_gpio_info'
>> drivers/gpio/gpio-rtd.c:71: warning: Function parameter or member 'num_dp' not described in 'rtd_gpio_info'
>> drivers/gpio/gpio-rtd.c:71: warning: Function parameter or member 'num_gpa' not described in 'rtd_gpio_info'
>> drivers/gpio/gpio-rtd.c:71: warning: Function parameter or member 'num_gpda' not described in 'rtd_gpio_info'
>> drivers/gpio/gpio-rtd.c:71: warning: Function parameter or member 'num_deb' not described in 'rtd_gpio_info'

vim +71 drivers/gpio/gpio-rtd.c

    34	
    35	/**
    36	 * struct rtd_gpio_info - Specific GPIO register information
    37	 * @name: GPIO device name
    38	 * @type: RTD GPIO ID
    39	 * @gpio_base: GPIO base number
    40	 * @num_gpios: Number of GPIOs
    41	 * @dir_offset: Offset for GPIO direction registers
    42	 * @dato_offset: Offset for GPIO data output registers
    43	 * @dati_offset: Offset for GPIO data input registers
    44	 * @ie_offset: Offset for GPIO interrupt enable registers
    45	 * @dp_offset: Offset for GPIO detection polarity registers
    46	 * @gpa_offset: Offset for GPIO assert interrupt status registers
    47	 * @gpda_offset: Offset for GPIO deassert interrupt status registers
    48	 * @deb_offset: Offset for GPIO debounce registers
    49	 */
    50	struct rtd_gpio_info {
    51		const char		*name;
    52		enum rtd_gpio_type	type;
    53		unsigned int		gpio_base;
    54		unsigned int		num_gpios;
    55		u8			*dir_offset;
    56		u8			num_dir;
    57		u8			*dato_offset;
    58		u8			num_dato;
    59		u8			*dati_offset;
    60		u8			num_dati;
    61		u8			*ie_offset;
    62		u8			num_ie;
    63		u8			*dp_offset;
    64		u8			num_dp;
    65		u8			*gpa_offset;
    66		u8			num_gpa;
    67		u8			*gpda_offset;
    68		u8			num_gpda;
    69		u8			*deb_offset;
    70		u8			num_deb;
  > 71	};
    72	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki