linux-kernel - Re: [PATCH] checkpatch: add judgment condition for Kconfig help test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2023 06:52:44 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Cixi Geng <cixi.geng@...ux.dev>, apw@...onical.com, joe@...ches.co,
        dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
        akpm@...ux-foundation.org, rdunlap@...radead.org,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Cosmin Tanislav <demonsingur@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Maksim Kiselev <bigunclemax@...il.com>,
        Liam Beguin <liambeguin@...il.com>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
        Marius Cristea <marius.cristea@...rochip.com>,
        ChiaEn Wu <chiaen_wu@...htek.com>,
        Niklas Schnelle <schnelle@...ux.ibm.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Industrial I/O <linux-iio@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: add judgment condition for Kconfig help test

On Thu, Nov 16, 2023 at 11:39:04PM +0800, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@...soc.com>
> 
> The has_help only counted the  situation which the patch file add
> a help line, when the config was renamed and  modify description,
> the has_help is zero for the "help" line not added.
> 
> here is one case:
>     the modify file: drivers/iio/adc/Kconfig  line(1047)
> 
>     -config SC27XX_ADC
>     +config SPRD_ADC
>      	tristate "Spreadtrum SC27xx series PMICs ADC"
>      	depends on MFD_SC27XX_PMIC || COMPILE_TEST
>     +	depends on ARCH_SPRD
>      	help
>     -	  Say yes here to build support for the integrated ADC inside the
>     -	  Spreadtrum SC27xx series PMICs.
>     +	  Say yes here to build support for the integrated ADC inside of the
>     +	  Spreadtrum SC27xx and UMPxx series PMICs.
> 
>      	  This driver can also be built as a module. If so, the module
>      	  will be called sc27xx_adc.
> 
> the checkpatch result:
>     WARNING: please write a help paragraph that fully describes the config symbol
>     #23: FILE: drivers/iio/adc/Kconfig:1050:
>     +config SPRD_ADC
>     +	tristate "Spreadtrum's ADC PMICs driver"
>      	depends on MFD_SC27XX_PMIC || COMPILE_TEST
>     +	depends on ARCH_SPRD
>      	help
>     +	  Say yes here to build support for the integrated ADC inside of the
>     +	  Say yes here to build support for the integrated ADC inside of the
>     +	  Say yes here to build support for the integrated ADC inside of the
>     +	  Spreadtrum SC27xx and UMPxx series PMICs.
> 
>      	  This driver can also be built as a module. If so, the module
>      	  will be called sc27xx_adc.
> 
>     total: 0 errors, 1 warnings, 17 lines checked

This confuses me. What are you trying to achieve there?

Confused...


-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)