linux-kernel - RE: [PATCH 1/1] iommu/vt-d: Add MTL to quirk list to skip TE disabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB527667F09E2FAD729AE2BC2C8CB0A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Thu, 16 Nov 2023 03:27:27 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Lu Baolu <baolu.lu@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>,
        "Will Deacon" <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        "Jason Gunthorpe" <jgg@...pe.ca>
CC:     "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Abdul Halim, Mohd Syazwan" <mohd.syazwan.abdul.halim@...el.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 1/1] iommu/vt-d: Add MTL to quirk list to skip TE
 disabling

> From: Lu Baolu <baolu.lu@...ux.intel.com>
> Sent: Thursday, November 16, 2023 10:23 AM
> 
> From: "Abdul Halim, Mohd Syazwan"
> <mohd.syazwan.abdul.halim@...el.com>
> 
> The VT-d spec requires (10.4.4 Global Command Register, TE field) that:
> 
> Hardware implementations supporting DMA draining must drain any in-flight
> DMA read/write requests queued within the Root-Complex before
> completing
> the translation enable command and reflecting the status of the command
> through the TES field in the Global Status register.

this talks about 'enable'...

> 
> Unfortunately, some integrated graphic devices fail to do so after some
> kind of power state transition. As the result, the system might stuck in
> iommu_disable_translation(), waiting for the completion of TE transition.

...while this fixes 'disable'. wrong citation?

> @@ -5080,7 +5080,7 @@ static void quirk_igfx_skip_te_disable(struct
> pci_dev *dev)
>  	ver = (dev->device >> 8) & 0xff;
>  	if (ver != 0x45 && ver != 0x46 && ver != 0x4c &&
>  	    ver != 0x4e && ver != 0x8a && ver != 0x98 &&
> -	    ver != 0x9a && ver != 0xa7)
> +	    ver != 0x9a && ver != 0xa7 && ver != 0x7d)
>  		return;
> 

this fix alone is fine, but I found this quirk overall is not cleanly handled.

Basically it sets iommu_skip_te_disable as true, leading to early return
in iommu_disable_translation():

	if (iommu_skip_te_disable && iommu->drhd->gfx_dedicated &&
	   (cap_read_drain(iommu->cap) || cap_write_drain(iommu->cap)))
		return;

However the caller of iommu_disable_translation() is not aware of this
quirk and continues as if the iommu is disabled. IMHO this is problematic
w/o meeting the caller's assumption.

e.g. kdump and suspend. We may want to abort those paths early in case
of such quirk...