linux-kernel - Re: [PATCH v2] net/tcp: use kfree_sensitive() instend of kfree() in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+B2gNO7-Mnai59Tpn44tomfLN1m9NnSEMq-qkt7AyyRw@mail.gmail.com>
Date:   Thu, 16 Nov 2023 09:44:03 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Minjie Du <duminjie@...o.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "open list:NETWORKING [TCP]" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com
Subject: Re: [PATCH v2] net/tcp: use kfree_sensitive() instend of kfree() in
 two functions

On Thu, Nov 16, 2023 at 3:22 AM Minjie Du <duminjie@...o.com> wrote:
>
> key might contain private information, so use kfree_sensitive to free it.
> In tcp_time_wait_init() and tcp_md5_twsk_free_rcu() use kfree_sensitive().
>
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>

You have not addressed my prior feedback.

3) You forgot tcp_time_wait_init(), tcp_md5_do_del(), tcp_md5_key_copy(),
    tcp_md5_do_add(), tcp_clear_md5_list().