linux-kernel - arch/riscv/kernel/module.c:48:19: sparse: sparse: symbol 'relocation_hashtable' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202311160958.D9SGclUM-lkp@intel.com>
Date:   Thu, 16 Nov 2023 09:29:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Charlie Jenkins <charlie@...osinc.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Palmer Dabbelt <palmer@...osinc.com>
Subject: arch/riscv/kernel/module.c:48:19: sparse: sparse: symbol
 'relocation_hashtable' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c42d9eeef8e5ba9292eda36fd8e3c11f35ee065c
commit: 8fd6c5142395a106b63c8668e9f4a7106b6a0772 riscv: Add remaining module relocations
date:   8 days ago
config: riscv-randconfig-r133-20231115 (https://download.01.org/0day-ci/archive/20231116/202311160958.D9SGclUM-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231116/202311160958.D9SGclUM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311160958.D9SGclUM-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   WARNING: invalid argument to '-march': '_zihintpause'
>> arch/riscv/kernel/module.c:48:19: sparse: sparse: symbol 'relocation_hashtable' was not declared. Should it be static?
>> arch/riscv/kernel/module.c:50:18: sparse: sparse: symbol 'used_buckets_list' was not declared. Should it be static?
   arch/riscv/kernel/module.c:68:25: sparse: sparse: cast to restricted __le16
   arch/riscv/kernel/module.c:68:55: sparse: sparse: cast to restricted __le16
   arch/riscv/kernel/module.c:73:19: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] @@     got restricted __le16 [usertype] @@
   arch/riscv/kernel/module.c:73:19: sparse:     expected unsigned short [usertype]
   arch/riscv/kernel/module.c:73:19: sparse:     got restricted __le16 [usertype]
   arch/riscv/kernel/module.c:74:19: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] @@     got restricted __le16 [usertype] @@
   arch/riscv/kernel/module.c:74:19: sparse:     expected unsigned short [usertype]
   arch/riscv/kernel/module.c:74:19: sparse:     got restricted __le16 [usertype]
   arch/riscv/kernel/module.c:81:20: sparse: sparse: cast to restricted __le16
   arch/riscv/kernel/module.c:86:17: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] @@     got restricted __le16 [usertype] @@
   arch/riscv/kernel/module.c:86:17: sparse:     expected unsigned short [usertype]
   arch/riscv/kernel/module.c:86:17: sparse:     got restricted __le16 [usertype]

vim +/relocation_hashtable +48 arch/riscv/kernel/module.c

    42	
    43	unsigned int initialize_relocation_hashtable(unsigned int num_relocations);
    44	void process_accumulated_relocations(struct module *me);
    45	int add_relocation_to_accumulate(struct module *me, int type, void *location,
    46					 unsigned int hashtable_bits, Elf_Addr v);
    47	
  > 48	struct hlist_head *relocation_hashtable;
    49	
  > 50	struct list_head used_buckets_list;
    51	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki